Skip to content

Revise CFD simulation statistics in README#993

Merged
sbryngelson merged 2 commits intoMFlowCode:masterfrom
sbryngelson:readme
Sep 3, 2025
Merged

Revise CFD simulation statistics in README#993
sbryngelson merged 2 commits intoMFlowCode:masterfrom
sbryngelson:readme

Conversation

@sbryngelson
Copy link
Copy Markdown
Member

@sbryngelson sbryngelson commented Sep 3, 2025 •
edited by qodo-code-review bot
Loading

User description

update readme

PR Type

Documentation

Description

  • Update CFD simulation record from 101 to 200 trillion grid points

  • Add Gordon Bell Prize finalist achievement

  • Increase LLNL El Capitan APU count to 43K

  • Fix formatting inconsistency in regression tests section

Diagram Walkthrough

flowchart LR
  A["CFD Simulation Stats"] --> B["101T → 200T grid points"]
  A --> C["Add Gordon Bell Prize"]
  D["Hardware Specs"] --> E["36K → 43K APUs"]
  F["Formatting"] --> G["Fix regression tests bullet"]
Loading

File Walkthrough
Relevant files
Documentation
README.md
Update simulation records and hardware specifications       

README.md

  • Updated CFD simulation record from 101 to 200 trillion grid points
  • Added Gordon Bell Prize finalist achievement and 1 quadrillion degrees
    of freedom
  • Increased LLNL El Capitan APU count from 36K to 43K
  • Fixed formatting inconsistency in regression tests section
 +3/-3     

Copilot AI review requested due to automatic review settings September 3, 2025 00:09
Copilot AI reviewed Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MFC simulation statistics and achievements in the README to reflect more recent milestones and accurate information as of September 2025.

  • Updates the largest CFD simulation record from 101 trillion to 200 trillion grid points
  • Adds mention of 1 quadrillion degrees of freedom and 2025 Gordon Bell Prize finalist status
  • Corrects the scaling information for LLNL El Capitan from >36K to >43K AMD APUs
  • Fixes formatting inconsistency in the regression tests bullet point

@sbryngelson sbryngelson merged commit 0a68648 into MFlowCode:master Sep 3, 2025
12 checks passed
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review bot commented Sep 3, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Inaccuracy

Validate the updated claims (200T grid points, 1 quadrillion DoF, Gordon Bell finalist, and >43K APUs on El Capitan) and ensure citations/links support each statement.

 
MFC conducted the largest known, open CFD simulation at <a href="https://arxiv.org/abs/2505.07392" target="_blank">200 trillion grid points</a>, and 1 quadrillion degrees of freedom (as of September 2025), and is a 2025 Gordon Bell Prize finalist.

<p align="center">
Formatting Consistency

Mixed tab/space indentation in bullet lists may render inconsistently across viewers; align indentation for the hardware and CI bullets.

 
* GPU compatible on NVIDIA ([P/V/A/H]100, GH200, etc.) and AMD (MI[1/2/3]00+) GPU and APU hardware
* Ideal weak scaling to 100% of the largest GPU and superchip supercomputers
 	* \>43K AMD APUs (MI300A) on [LLNL El Capitan](https://hpc.llnl.gov/hardware/compute-platforms/el-capitan)
   	* \>3K AMD APUs (MI300A) on [LLNL Tuolumne](https://hpc.llnl.gov/hardware/compute-platforms/tuolumne)
	* \>33K AMD GPUs (MI250X) on [OLCF Frontier](https://www.olcf.ornl.gov/frontier/) 
	* \>10K NVIDIA GPUs (V100) on [OLCF Summit](https://www.olcf.ornl.gov/summit/) 
* Near compute roofline behavior
* RDMA (remote data memory access; GPU-GPU direct communication) via GPU-aware MPI on NVIDIA (CUDA-aware MPI) and AMD GPU systems
* Optional single-precision computation and storage

### Software robustness and other features

* [Fypp](https://fypp.readthedocs.io/en/stable/fypp.html) metaprogramming for code readability, performance, and portability
* Continuous Integration (CI)
	* \>500 Regression tests with each PR.
 		* Performed with GNU (GCC), Intel (oneAPI), Cray (CCE), and NVIDIA (NVHPC) compilers on NVIDIA and AMD GPUs.
		* Line-level test coverage reports via [Codecov](https://app.codecov.io/gh/MFlowCode/MFC) and `gcov`
	* Benchmarking to avoid performance regressions and identify speed-ups

qodo-code-review[bot]
qodo-code-review bot reviewed Sep 3, 2025
View reviewed changes
@sbryngelson sbryngelson deleted the readme branch September 5, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qodo-code-review qodo-code-review[bot] qodo-code-review[bot] left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

Review effort 1/5

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbryngelson